Archive/LeakNet
Watch
3
0
Fork
You've already forked LeakNet
 0
Code Issues 314 Pull requests Projects Releases 3 Packages Wiki Activity Actions

vaudio_minimp3 doesn't have voice interface #379

New issue
Open
opened 2023-08-29 09:53:41 +00:00 by UAVXP · 5 comments
UAVXP commented 2023-08-29 09:53:41 +00:00 (Migrated from gitlab.com)
Copy link

We need either make one, use MiniMP3 for decoding and Miles for encoding, or get rid of minimp3 implementation

We need either make one, use MiniMP3 for decoding and Miles for encoding, or get rid of minimp3 implementation
UAVXP commented 2023-08-29 10:01:57 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
UAVXP (Migrated from gitlab.com) closed this issue 2023-08-29 10:19:45 +00:00
tyabus commented 2023-08-30 06:28:14 +00:00 (Migrated from gitlab.com)
Copy link

We can use speex, celt, opus, etc codecs, why do we even need miles for voice chat (i have never seen it work in beta)? It provides poor quality due to bandwidth limits of the early 2000s

We can use speex, celt, opus, etc codecs, why do we even need miles for voice chat (i have never seen it work in beta)? It provides poor quality due to bandwidth limits of the early 2000s
UAVXP commented 2023-08-30 07:06:58 +00:00 (Migrated from gitlab.com)
Copy link

I thought minimp3 had that voice codec feature btw. Unfortunately, not

I thought minimp3 had that voice codec feature btw. Unfortunately, not
tyabus commented 2023-09-01 14:33:48 +00:00 (Migrated from gitlab.com)
Copy link

It shouldn't have a voice decoder, that's speex/celt/opus's job, valve basically retired miles's voice codec since orangebox engine update, i think. And also we are using ancient version of miles, which has an exploit with mp3 decoding that basically lets you do a code execution, so maybe someone have found a voice decoder exploit that would do the same or just crash all the clients/the server.

It shouldn't have a voice decoder, that's speex/celt/opus's job, valve basically retired miles's voice codec since orangebox engine update, i think. And also we are using ancient version of miles, which has an exploit with mp3 decoding that basically lets you do a code execution, so maybe someone have found a voice decoder exploit that would do the same or just crash all the clients/the server.
UAVXP commented 2023-09-02 00:50:50 +00:00 (Migrated from gitlab.com)
Copy link

Well, we can try to port Speex one from Source Engne 2007 leak then, just to get rid of that Miles thingy. I think I can do this, but a bit later

Well, we can try to port Speex one from Source Engne 2007 leak then, just to get rid of that Miles thingy. I think I can do this, but a bit later
UAVXP (Migrated from gitlab.com) reopened this issue 2023-09-02 00:50:53 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
rewrite
feat/vscode-integration
megapatch5
megapatch5-steam3
bugfix/studiomdl_v37_incorrect_mdl_structure
feat/alien-assassin-npc
steam3
rewrite-basetest
UAVXP-rewrite-patch-80728
feat/getvidmembytes-backport
rewrite-vmtedit_fix
master
premake
cmaketest
311-check-on-alt-tab-from-fullscreen
vector_normalize_experimental
xorusr-experiments
2010
vgui_app_test
masterserver_test
prediction_fix
sm3
2.0.5.0
2.0.4.0
2.0.3.0
Labels
Clear labels   
branch-old

   
branch-rewrite

   
bug

   
cannot-reproduce

   
duplicate

   
enhancement

   
fixed-old

   
fixed-rewrite

   
game

   
invalid

   
might-return-to

   
need-feedback

   
need-search

   
question

   
tools

   
wiki

   
wontfix
No labels
branch-old
branch-rewrite
bug
cannot-reproduce
duplicate
enhancement
fixed-old
fixed-rewrite
game
invalid
might-return-to
need-feedback
need-search
question
tools
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
LeakNet 2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Archive/LeakNet#379
No description provided.